Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoking permission at SelectDatabaseActivity crashes app #56

Open
aper-project opened this issue May 7, 2021 · 0 comments
Open

Revoking permission at SelectDatabaseActivity crashes app #56

aper-project opened this issue May 7, 2021 · 0 comments

Comments

@aper-project
Copy link

Hi, there, I've found a crash in version 1.44, which is downloaded from F-Droid.

I seems that it is related to the dangerous permission android.permission.READ_EXTERNAL_STORAGE and is triggered in the SelectDatabaseActivity. It can be caused when the app attempts to read external storage without either permission checking (via checkSelfPermission) nor permission request (via requestPermissions).

Reproduce crash

This crash can be reproduced on my Samsung device, following the steps:

  1. grant the storage permission for the app
  2. create a database in the main activity
  3. select a database and enter the SelectDatabaseActivity
  4. go to the system setting and revoke the storage permission
  5. back to the app and it crashes

@RyuzakiKK
Could you help me review this issue? If you need more information, I may make a video showing the crash. Very thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant