Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Windows Terminal as default, the Hide console option doesn't work #3246

Open
voldemort2826 opened this issue Mar 31, 2022 · 9 comments
Labels
bug Something isn't working gui Related to Ryujinx.Ui

Comments

@voldemort2826
Copy link
Contributor

voldemort2826 commented Mar 31, 2022

Bug Report

What's the issue you encountered?

If a user set Windows Terminal as default (replacing the classic Command Prompt), the Hide console option doesn't work.
In addition, ticking that option will show a tiny window.

Edit: runing Ryujinx as admin uses command prompt instead of terminal, thus hiding the console.

How can the issue be reproduced?

  1. Install Windows Terminal from Microsoft Store.
  2. Open it, click the down-arrow button > Settings. In Default terminal application choose Windows Terminal.
  3. Open Ryujinx as usual.

Log file

Don't think this is needed, more likely related to the code that is responsible for hiding console.

Environment?

  • Ryujinx version: 1.1.85
  • System Specs:
    • OS: Happens on Windows 11, build 22581.200.
      Someone can test this on Windows 10 or earlier Win 11 version to see if this happens.

Additional context?

Screenshots of the issue:

@MutantAura MutantAura added bug Something isn't working gui Related to Ryujinx.Ui labels Apr 10, 2022
@voldemort2826
Copy link
Contributor Author

After checking the PR #3170 I found that GetConsoleWindow doesn't work with Windows Terminal, thus failing to hide the console with it. On official docs it seems like this is by design and therefore we can't do anything about it.

@BParks21

This comment was marked as off-topic.

@merryhime
Copy link
Contributor

merryhime commented Nov 15, 2022

See also #3779.

@sidewinder94
Copy link

sidewinder94 commented Dec 31, 2022

If Windows terminal is your default, whatever the reason. A workaround to get ryujinx to still use the "traditional" console host is to start ryujonx from the console host.

Easiest way to do that if you've installed ryujinx, is to change a shortcut used to launch it.

On the target field, add "conhost.exe" before the pull path to the ryyujinx executable.
You will have to change the icon afterwards, because it will then take the one of conhost.

I agree it's not a long term solution, but it should solve a couple issues.

(was originally posted in #3779, but I think this workaround is better suited to this issue)

@hyoretsu
Copy link

hyoretsu commented Jan 6, 2023

Windows Terminal is the default on Windows 11.

@WilliamLeGod
Copy link

Have u found a fix yet?

@Squall-Leonhart
Copy link

the default is actually "Let Windows Decide" which means there must be some way to Hint that you want Conhost.

@spotanjo3
Copy link

New late update didnt let me to hide it anymore. A bug again for this hide console option ?

@Squall-Leonhart
Copy link

Console hiding now has some underpinning work added to the windows terminal
microsoft/terminal#12464 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui Related to Ryujinx.Ui
Projects
None yet
Development

No branches or pull requests

9 participants