Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for HTTP/2 #13

Open
RustedBones opened this issue Jul 12, 2019 · 5 comments
Open

Provide support for HTTP/2 #13

RustedBones opened this issue Jul 12, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@RustedBones
Copy link
Owner

As of today, Akka Http only allows using HTTP2 with bindAndHandleAsync method. Since .recordMetrics returns a flow, I can't use this library with HTTP2 which only takes HttpRequest ⇒ Future[HttpResponse] as handler.

@RustedBones RustedBones added the enhancement New feature or request label Jul 12, 2019
@RustedBones RustedBones changed the title Provide support HTTP/2 Provide support for HTTP/2 Jul 21, 2019
@RustedBones
Copy link
Owner Author

async handler is now part of the API but connections metrics are not supported.

@bilal-fazlani
Copy link

bilal-fazlani commented Jul 24, 2019

The latest release of Akka HTTP has improvements for HTTP 2. Not sure if it helps

https://doc.akka.io/docs/akka-http/current/release-notes/10.1.x.html#akka-http2-support

@RustedBones
Copy link
Owner Author

Thanks for the notification @bilal-fazlani !

There are no significant changes on the API but I spotted this TODO comment on the Http2Ext that indicates a possible unification with Http API.

At this point the connections metrics could be added for Http2.

@RustedBones
Copy link
Owner Author

Small update on this.

Seems the unification goes the opposite way in akka-http 10.2. It favors the function handler instead of the stream, making it more difficult to access connections metrics

@RustedBones
Copy link
Owner Author

TelemetrySpi has been added to akka-http. akka-http-metrics should provide an implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants