Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line ending patterns in all execute testcases #2817

Open
CohenArthur opened this issue Jan 26, 2024 · 3 comments · May be fixed by #2980
Open

Fix line ending patterns in all execute testcases #2817

CohenArthur opened this issue Jan 26, 2024 · 3 comments · May be fixed by #2980
Labels
good-first-pr

Comments

@CohenArthur
Copy link
Member

The correct pattern for an end of line should be \r*\n+ to ensure compatibility with all platforms
@badumbatish
Copy link
Contributor

Can I just do sed -i -e 's/$/\r/' for each file in execute/ dir ?

@CohenArthur
Copy link
Member Author

@badumbatish some of them are more correct than others, and some of them are also nested - but yes, this is basically it :) it's quite a simple issue, I'll mark it with good-first-pr

@badumbatish
Copy link
Contributor

badumbatish commented May 8, 2024 •
edited

is there a way to test that the changes I perform on these files would work?

Edited: I ran the tests and two are failing due to \r\n, i fixed it.

@badumbatish badumbatish linked a pull request May 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix all tests in execute to be \r\n badumbatish/gccrs
2 participants
@badumbatish @CohenArthur