Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: What exactly does the Deep Scan option do? #35

Open
marek22k opened this issue Feb 13, 2024 · 1 comment · May be fixed by #36
Open

Question: What exactly does the Deep Scan option do? #35

marek22k opened this issue Feb 13, 2024 · 1 comment · May be fixed by #36

Comments

@marek22k
Copy link

Hello,

I would like to add pcapfix to tldr. I came across a discrepancy in the Deep Scan documentation with a reviewer.

In the deep scan option it says:

This option will force pcapfix to scan for any packet inside the whole file (instead of the first 262144 (max snaplen) bytes only).

But in the note section it says:

In classic pcap files, pcapfix will only scan the first 65536 bytes (maximum packet length) for a proper first packet.

Did I understand correctly that pcapng files are always repaired completely and pcap files only partially? And if so, how big is this part?

@vitorhcl
Copy link

vitorhcl commented Feb 13, 2024

I've found the code :) Since cf16a13, the max snaplen is 262144. See the following code snippet:

pcapfix/pcap.h

Line 27 in 00b278a

#define PCAP_MAX_SNAPLEN 262144 /* the maximum snap length, should be 256K instead of 64K nowadays */

marek22k added a commit to marek22k/pcapfix that referenced this issue Feb 13, 2024
Closes Rup0rt#35

Thanks to @vitorhcl for the research.
@marek22k marek22k linked a pull request Feb 13, 2024 that will close this issue
marek22k added a commit to marek22k/pcapfix that referenced this issue Feb 13, 2024
Closes Rup0rt#35

Thanks to @vitorhcl for the research.

Signed-off-by: Marek Küthe <m.k@mk16.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants