Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial new ownership tasks #93

Open
7 of 8 tasks
RonnyPfannschmidt opened this issue Apr 1, 2021 · 29 comments
Open
7 of 8 tasks

initial new ownership tasks #93

RonnyPfannschmidt opened this issue Apr 1, 2021 · 29 comments
Assignees
Labels

Comments

@RonnyPfannschmidt
Copy link
Owner

RonnyPfannschmidt commented Apr 1, 2021

  • place into a organisation
  • figure what exactly the license means for the file headers (i'd like to remove the dunder items in each file if permissible) cc @jfinkhaeuser
  • update docs/templates to the owner change
  • invite co-maintainers from snok CC @snok
  • set up pypi credentials for maintainers and set up release automation

followup to #91

@jfinkhaeuser
Copy link
Collaborator

jfinkhaeuser commented Apr 1, 2021

I have no objections to any changes you want to make. Of course I have preferences, but I gave up the privilege of enforcing them when transferring the project :)

One of my preferences has been to avoid a CLA (bot) or similar, and take contributions on a gentleperson's understanding that nobody will ever do anything horrible with them. Hence I went with simple copyright/license notices in file headers.

With regards to licenses, IANAL, but I keep being told that any file without a license or license mention is effectively unlicensed, so would fall under copyright of the authors. I'd leave that __license__ thing in every file, if it was up to me.

I also have a bunch of additional/modified items:

  • remove funding links to jfinkhaeuser
  • pypi transfer is apparently difficult; the .travis.yml contains encrypted credentials. We can leave them there for the time being, but moving to other credentials would be sensible.
  • update the openapi website to reflect the new git repo link
  • buy you new maintainers a beer at the next fosdem beer event we can attend in person ;)
  • ensure github.io website either works or is (re-)moved

@RonnyPfannschmidt
Copy link
Owner Author

@jfinkhaeuser i believe all that's needed for pypi is adding me as a owner, then i can create a new token (as the encryption is invalid for the new location anyway)

thanks for the extra items 👍

@RonnyPfannschmidt
Copy link
Owner Author

there will be no CLA, licensing will stay MIT, i'll crosscheck the meaning of the HEADER again to be sure (laws are hell)

RonnyPfannschmidt added a commit that referenced this issue Apr 1, 2021
addresses a item in #93
@RonnyPfannschmidt
Copy link
Owner Author

@jfinkhaeuser do you remember what the secret here is for ?

prance/.travis.yml

Lines 47 to 49 in 773e87f

env:
global:
- secure: OBNymO/NhhWmcI/Vqs4TcxYCSPoDAblnurdjC11h0xi0OVNfddhKEIlcump3G7vZZNJucepp2SOVV8rrUE1ATbxQnZzMwAarfW61l4aoAXP1y4oZkVrDVMdXTKMU2t1iXpjU7rQSCnJ9GhLyyC8I5EJTeJR9nwhts2sh186QyJM3rnjdt8C6PULh48YvpU9sKoazShzqL0s+L8wHQeh1BTRu7DMFQwmZl+dFc1RSO/Q3hpVIBk/9cdlCixWQZzPu14Z0gjX76qsVixKJ1oB+2wVIiMDwMS1h7HGQhJTY3B47orAkiSK8EbmPBBKzqD0oNEq9e98x7V/+Hre7Hw4EoMLZHeBcyeQ998T7XbYpR1/19nVyXb8epZ6q6Uo7q5+GWUr+cDdY+d/AzGed4uOh7YD+mqn+BVg+h5JyGabRpfIAeeCbwQ5Uq9WSdVhcyDeqAwSsC2uGuMSuZaTgs0aU3uXOgZpmCPA35Qs0qVOFldeId7FU+JW+ij98/B+dgTqB7ZXCFsG+BTmYxnE3Iza6dtJoe5NEYadEXiPMZG3BBcra9UN77ltmmsfentujhkgcof1H+1o85nTY2ry6SkTICmibt7egJbiKb1jr0yn0FqBvzUKJCTqIN3gQFWeC2A2FQej2EvxMcx/QRmFPK6ylVQJjbZHsoGJs/yf9fuLlyBg=

@jfinkhaeuser
Copy link
Collaborator

@jfinkhaeuser do you remember what the secret here is for ?

prance/.travis.yml

Lines 47 to 49 in 773e87f

env:
global:
- secure: OBNymO/NhhWmcI/Vqs4TcxYCSPoDAblnurdjC11h0xi0OVNfddhKEIlcump3G7vZZNJucepp2SOVV8rrUE1ATbxQnZzMwAarfW61l4aoAXP1y4oZkVrDVMdXTKMU2t1iXpjU7rQSCnJ9GhLyyC8I5EJTeJR9nwhts2sh186QyJM3rnjdt8C6PULh48YvpU9sKoazShzqL0s+L8wHQeh1BTRu7DMFQwmZl+dFc1RSO/Q3hpVIBk/9cdlCixWQZzPu14Z0gjX76qsVixKJ1oB+2wVIiMDwMS1h7HGQhJTY3B47orAkiSK8EbmPBBKzqD0oNEq9e98x7V/+Hre7Hw4EoMLZHeBcyeQ998T7XbYpR1/19nVyXb8epZ6q6Uo7q5+GWUr+cDdY+d/AzGed4uOh7YD+mqn+BVg+h5JyGabRpfIAeeCbwQ5Uq9WSdVhcyDeqAwSsC2uGuMSuZaTgs0aU3uXOgZpmCPA35Qs0qVOFldeId7FU+JW+ij98/B+dgTqB7ZXCFsG+BTmYxnE3Iza6dtJoe5NEYadEXiPMZG3BBcra9UN77ltmmsfentujhkgcof1H+1o85nTY2ry6SkTICmibt7egJbiKb1jr0yn0FqBvzUKJCTqIN3gQFWeC2A2FQej2EvxMcx/QRmFPK6ylVQJjbZHsoGJs/yf9fuLlyBg=

Nope... sorry. That is actually kind of weird to see there.

@RonnyPfannschmidt
Copy link
Owner Author

@jfinkhaeuser please add me as pypi maintainer/owner

@jfinkhaeuser
Copy link
Collaborator

jfinkhaeuser commented Apr 1, 2021

@RonnyPfannschmidt What's your username there?

@RonnyPfannschmidt
Copy link
Owner Author

@jfinkhaeuser ronny

@jfinkhaeuser
Copy link
Collaborator

Thanks, invite is sent @RonnyPfannschmidt

@jezdez
Copy link

jezdez commented Apr 7, 2021

there will be no CLA, licensing will stay MIT, i'll crosscheck the meaning of the HEADER again to be sure (laws are hell)

For the record, the license isn't MIT at the moment but MITNFA (MIT +no-false-attribs License), which isn't OSI approved. Some background: Level/packager#1

@RonnyPfannschmidt
Copy link
Owner Author

@jezdez thanks for the ref, that one is a bit of a headache

@jfinkhaeuser is there anything preventing going with a OSI approved variant lie MIT or Artistic?

@jfinkhaeuser
Copy link
Collaborator

@RonnyPfannschmidt Artistic 2.0 is fine with me. GPLv3 is fine with me, too, but may not be with others :)

@jfinkhaeuser
Copy link
Collaborator

If you want I can create a PR for the license change so you can have my signature on that :)

@RonnyPfannschmidt
Copy link
Owner Author

@jezdez i believe Artistic 2.0 is fine for jazzband?

@jfinkhaeuser once we agreed on the final license that would be most appreciated 👍

@jezdez
Copy link

jezdez commented Apr 8, 2021

@jezdez i believe Artistic 2.0 is fine for jazzband?

Well, MITNFA is "fine" as well, but if you want to increase the likelyhood that the library is going to be maintained in the future, I would suggest to use an OSI approved license.

@Goldziher
Copy link
Contributor

I don't mind giving a hand :).

@RonnyPfannschmidt
Copy link
Owner Author

short followup from openapi tools, a mail to team@openapitools.org with detail would be required to start the process
it should included maintenance plans and details required from the openapi tools team
i think for now i'll focus on jazzband

personally im currently solving something else with time pressure, i plan to get back to prance right after that resolves

@RonnyPfannschmidt
Copy link
Owner Author

@jezdez did i understand you correct that, current license would be fine but osi approved like Artistic2/plain MIT wouldbe much better - does jazzband have any preference, or is whatever @jfinkhaeuser likes of those acceptable

@jfinkhaeuser
Copy link
Collaborator

Technically, it's your project now, and I do not need to give approval. But I appreciate the gesture!

@jezdez
Copy link

jezdez commented Apr 14, 2021

@jezdez did i understand you correct that, current license would be fine but osi approved like Artistic2/plain MIT wouldbe much better - does jazzband have any preference, or is whatever @jfinkhaeuser likes of those acceptable

Sorry, I described the license as "fine" in quotes above, indicating that it's not fine. Let me ellaborate.

Jazzband exists to make long-term maintenance easier. Choosing a non-OSI license (read: not "Open Source") decreases the chance for use in real world projects where license compatibility matters. Which in effect reduces the chance that someone wants to maintain the project in the future. As such I would strongly recommend to switch to an OSI-approved license to remove this risk, such as the regular MIT license.

@RonnyPfannschmidt
Copy link
Owner Author

@jezdez thanks for elaborating

@jfinkhaeuser i'd like to go MIT then

@jfinkhaeuser
Copy link
Collaborator

Sure!

@RonnyPfannschmidt
Copy link
Owner Author

@jezdez @jfinkhaeuser @Goldziher just a status update from my side

i have been very occupied for corona related personal life mitigation (vaccine related childcare downtimes) and work delivery targets

i'll pick this up hopefully by the end of this week, but latest by the end of next week
i'm then going to set up the license change and prepare for moving to jazzband

@Glutexo
Copy link
Collaborator

Glutexo commented May 14, 2021

update docs/templates to the owner change

should include the new issue template.

@RonnyPfannschmidt
Copy link
Owner Author

@jfinkhaeuser i think i finished most of the replacement tasks as well as the MIT Replacement now

i plan to push a first release today, then iterate

i started to use readthedocs for the docs building
i added pre-commit and will take a look at black in near future

i plan to add validation and refactoring tools for openapi specs soon-ish

@jfinkhaeuser
Copy link
Collaborator

Sounds awesome!

@RonnyPfannschmidt
Copy link
Owner Author

closing as complete

@snok i welcome maintainers joining

@jfinkhaeuser
Copy link
Collaborator

Not to raise a zombie here, but MITNFA has a SPDX identifier (MITNFA), so is a very well documented open source license.

https://spdx.org/licenses/MITNFA.html

@RonnyPfannschmidt
Copy link
Owner Author

Good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants