Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: documented macros #60

Open
jonpoveda opened this issue Feb 13, 2020 · 3 comments
Open

New feature: documented macros #60

jonpoveda opened this issue Feb 13, 2020 · 3 comments

Comments

@jonpoveda
Copy link

Adding a new parameter to the macro recording command to add some text could help to ease macro readability.

Idea 1: adding just a comment

!macro F [-1-1]s 0 # Fudge

!macro list
id: 0 Pattern: F Command: [-1-1]s Regexp: False Comment: Fudge

Idea 2: adding specific keys and values

!macro F [-1-1]s 0 Name=Fudge

!macro list
id: 0 Pattern: F Command: [-1-1]s Regexp: False Name: Fudge

@obiwankennedy
Copy link
Member

It's a good idea.

@obiwankennedy
Copy link
Member

obiwankennedy commented Feb 17, 2020

Right now, macro and aliases are stored inside json files. I worked to port data storage to database, I never put this work in production. it needs more tests. I may use the comment as a datatable key. So It may be mandatory to set a name.

@jonpoveda
Copy link
Author

jonpoveda commented Feb 17, 2020

@obiwankennedy it makes sense to have unique names, so it seems a good idea to use them as a key (or a hash of the name, but then it'll need an extra field for the actual name to display). Moreover, that will allow to delete (or even update) macros by name instead of by number. So, two features in one. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants