Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoupling from RocketChat #13

Open
MatheusFaria opened this issue Nov 30, 2017 · 1 comment
Open

Decoupling from RocketChat #13

MatheusFaria opened this issue Nov 30, 2017 · 1 comment

Comments

@MatheusFaria
Copy link
Contributor

This project is tightly coupled with RocketChat. It would be interesting to decouple it to make sure that other adapters can use it.

@diegodorgam
Copy link
Contributor

Would be cool, one way to do this is abstracting the adapter methods calls, in a lib file for example, where the methods could be switched according to the actual adapter in use.
Although would really need a closest watching about wich method exists and each adapter to maintain it bugless.
Today I think we are using the following rocketchat adapter's methods:

  • stream-notify-room
  • getUserRoles
  • livechat:transfer
  • livechat:saveInfo

And we're actually using some attributes from the response object, wich is generated in the adapter too, like res.envelope.user.roomType, res.robot.alias and res.robot.name. Probably would be wise to abstract that in some object too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants