Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Remove Markdown tags from in some parts of the app #1563

Closed
3 tasks done
rafaelks opened this issue Apr 19, 2018 · 2 comments · May be fixed by #2432
Closed
3 tasks done

[IMPROVEMENT] Remove Markdown tags from in some parts of the app #1563

rafaelks opened this issue Apr 19, 2018 · 2 comments · May be fixed by #2432
Assignees
@cardoso
Labels
👍 improvement
Projects
Cycle 05: 05/05 ~ 05/27 Cycle 12: 12/05 ~ 01/05
Milestone
3.3.0

Comments

@rafaelks
Copy link
Contributor

rafaelks commented Apr 19, 2018 •
edited by cardoso

  • In-app notifications;
  • Reply/Quote pop-up;
  • Push notifications
@rafaelks rafaelks added this to the 2.3.0 milestone Apr 19, 2018
@rafaelks rafaelks added this to Desirable in Cycle 05: 05/05 ~ 05/27 via automation Apr 19, 2018
@Sameesunkaria
Copy link
Collaborator

Sameesunkaria commented Apr 19, 2018 •
edited

@rafaelks for in-app notifications, the markdown should be removed from the backend.

There’s already an issue for that (posted by you) RocketChat/Rocket.Chat#9979.
You could maybe update it to mention the same requirement for desktop notifications? 🤔

@rafaelks rafaelks moved this from Desirable to To do in Cycle 05: 05/05 ~ 05/27 May 1, 2018
@rafaelks
Copy link
Contributor Author

@Sameesunkaria For now, we can remove the markdown by simply getting the cached value on Markdown library and transforming it in pure String (.string attribute of NSAttributedString). Would you mind doing this?

@Sameesunkaria Sameesunkaria mentioned this issue May 18, 2018
Merged
@rafaelks rafaelks modified the milestones: 3.0.0, 3.0.2 Jul 17, 2018
@rafaelks rafaelks added this to the 3.2.0 milestone Sep 6, 2018
@rafaelks rafaelks modified the milestones: 3.2.0, 3.3.0 Nov 6, 2018
This was referenced Dec 14, 2018
Open
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cardoso cardoso

Labels
👍 improvement
Projects
No open projects
Cycle 05: 05/05 ~ 05/27
  
To do
Cycle 12: 12/05 ~ 01/05
  
Done
Milestone
3.3.0
3 participants
@rafaelks @cardoso @Sameesunkaria