Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: checks if the hideUnreadStatus property is coming from the subscription #5649

Merged
merged 6 commits into from
May 22, 2024
Merged

regression: checks if the hideUnreadStatus property is coming from the subscription #5649

merged 6 commits into from
May 22, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Apr 10, 2024 •
edited

Proposed changes

Checks if the hideUnreadStatus property is coming from the subscription
Sometimes the property does not come from the backend, so it is false, which is not the expected behavior.

Issue(s)

resolve: #5644

How to test or reproduce

  • set these settings in a room:
    image
  • send a message in that room with another user.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-253

diegolmello
diegolmello reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior might have changed on a recent version of backend, but it could work for older servers.
Ideally we should identify when it changed, but we need to check at least on 3.11, v4 and v5.

@GleidsonDaniel
Copy link
Contributor Author

This behavior might have changed on a recent version of backend, but it could work for older servers. Ideally we should identify when it changed, but we need to check at least on 3.11, v4 and v5.

It hasn't changed, it's still the same, we just didn't check it correctly.
And now with some servers migrating and leaving some problematic fields, the problem has become more evident.
Looking at the history of changes, nothing has changed in the last year, for example, the rules are mostly rules with more than 3 years of implementation.

@GleidsonDaniel GleidsonDaniel merged commit a035211 into develop May 22, 2024
3 of 8 checks passed
@GleidsonDaniel GleidsonDaniel deleted the fix-subscription-status branch May 22, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chats with disabled notifications appear in Unread.
2 participants
@GleidsonDaniel @diegolmello