Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: right swipe to reply in quote #5486

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: right swipe to reply in quote #5486

wants to merge 1 commit into from

Conversation

SanjaySargam
Copy link
Contributor

Proposed changes

I suggest having a feature like left/right swipe the message to reply in quote. Because we generally use reply in quote in most of times. So it would be better if we have a shortcut for it.

Issue(s)

Fixes #5478

How to test or reproduce

  1. Go to Chats

Screenshots

WhatsApp.Video.2024-01-16.at.11.04.16.PM.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@SanjaySargam SanjaySargam marked this pull request as ready for review January 17, 2024 16:18
diegolmello
diegolmello reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't increase the complexity of a component without evaluating the impact of work on the codebase.
Message already has Touchable component.
There you'll see we make use of an already deprecated lib and we need to migrate away from it https://github.com/rnc-archive/react-native-platform-touchable

You should unify and consider the migration to RNGH on all Message's components.

app/containers/message/index.tsx
@@ -1,5 +1,6 @@
import React from 'react';
import { Keyboard, ViewStyle } from 'react-native';
import { Keyboard, ViewStyle, Animated } from 'react-native';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you use stock RN's Animated instead of reanimated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will use Animated from 'react-native-reanimated'

app/containers/message/index.tsx
isPreview={isPreview}
/>
</MessageContext.Provider>
<PanGestureHandler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to evaluate and show us if this new gesture is impacting the other buttons inside Message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello diegolmello left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Right/Left swipe the message to reply in quote
2 participants
@SanjaySargam @diegolmello