Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update members immediately #5474

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: update members immediately #5474

wants to merge 1 commit into from

Conversation

SanjaySargam
Copy link
Contributor

Proposed changes

Issue(s)

Fixes #5473

How to test or reproduce

  1. Create Channel
  2. Add users to channel

Screenshots

WhatsApp.Video.2024-01-10.at.8.13.58.PM.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

GleidsonDaniel
GleidsonDaniel requested changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is not a valid solution, given that you are trying to solve the problem of showing users when they are added to the list.
However, your solution makes a call every time the user enters this screen, even though no user has been added or removed.

The app is offline first and has a focus on performance, any improvement must consider these two points.
This call adds additional overhead for a multitude of users who were not experiencing this "problem".

@SanjaySargam
Copy link
Contributor Author

@GleidsonDaniel Ok. Is there any alternative and best solution for this ?

@GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel Ok. Is there any alternative and best solution for this ?

It would be adding a check or call back warning that there is a new user and only then calling the api to look for new users.
Something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GleidsonDaniel GleidsonDaniel GleidsonDaniel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Update members after adding users in RoomMembersVIew
2 participants
@SanjaySargam @GleidsonDaniel