Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Error Handling for "Message Too Long" #384

Closed
Akshun-01 opened this issue Jan 5, 2024 · 7 comments · Fixed by #493 · May be fixed by #391
Closed

Proper Error Handling for "Message Too Long" #384

Akshun-01 opened this issue Jan 5, 2024 · 7 comments · Fixed by #493 · May be fixed by #391
Labels
bug Something isn't working

Comments

@Akshun-01
Copy link
Contributor

Description:

In Embedded Chats, if the message is too long then it gives an error message of
Error sending message, log in again.
and logs the user out.

Getting logged out for sending long texts is a not very likely user experience, this should be properly handled with an Error message ( similar to what is done on RocketChat).

Steps to reproduce:

  1. Try to send a very long text or code.

Expected behavior:

image

Actual behavior:

Screencast.from.01-02-2024.05.52.29.PM.webm
@Akshun-01 Akshun-01 added the bug Something isn't working label Jan 5, 2024
@Akshun-01
Copy link
Contributor Author

@abhinavkrin @sidmohanty11
Please confirm if this issue needs attention. I would love to start working on this.

@rahat2134
Copy link

yup! I also want to work on this issue.

@manascb1344
Copy link

Hey @abhinavkrin! 🚀 Just wanted to give you a heads up on the latest changes. Fixed the long message issue in the ChatInput component, now it shows a friendly error toast for character limit exceeded. Also added guidance to send long messages as attachments. No more unexpected logouts! Check it out and let me know if it's all good. 🙌 #384

@Akshun-01
Copy link
Contributor Author

Hey @sidmohanty11 @abhinavkrin,
I have completed the modal and error handling. I am currently writing the code to change message to file and send it as an attachment. It is a bit tricky. So I just wanted to confirm before moving forward with this issue.
Is this issue approved?

Will raise a draft soon! ^^

@Akshun-01
Copy link
Contributor Author

Update :

Hey, I have added the convert to file logic as well. Here is the current status.

longMessgae.mp4

Some bugs need attention, I will try to fix them soon and send a PR (or should I send a draft pr, so you can also see the code changes ?)

[Any suggestions or feedback would be appreciated] @sidmohanty11

@Spiral-Memory
Copy link
Contributor

Great find, @Akshun-01 , and great work fixing this as well.

@Akshun-01 Akshun-01 mentioned this issue Mar 4, 2024
3 tasks
@Akshun-01
Copy link
Contributor Author

Hello @abhinavkrin @sidmohanty11,
resolved all the linting and conflicting issues. The changes are ready for review.
Do take a look in your free time thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants