Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to add unit tests? #4

Open
CanoeFZH opened this issue Oct 9, 2019 · 4 comments
Open

Any plan to add unit tests? #4

CanoeFZH opened this issue Oct 9, 2019 · 4 comments

Comments

@CanoeFZH
Copy link

CanoeFZH commented Oct 9, 2019

Hi, I think this is a great project that gives many implementation and great guidance for number theory learning. But I think it would be better to add test cases for these functions.
I have good willing to add unit tests to these splendid functions. Call for more discussion about this topic here.

@Robert-Campbell-256
Copy link
Owner

Very good idea. I had some unit tests laying around for my own use, but a more cleanly done set would improve the project.

@Robert-Campbell-256
Copy link
Owner

Made a start with an existing unittest script for numbthy.py, running under Travis. More work is needed, primarily for the other files.

@CanoeFZH
Copy link
Author

Congratulation! Do you have a priority list? I can have a try.

@Robert-Campbell-256
Copy link
Owner

No priority list - it's all open. Any suggestions are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants