Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fault When Creating Frozen Bitmap From MMapped #363

Open
jacksonrnewhouse opened this issue Jun 24, 2022 · 2 comments
Open

Fault When Creating Frozen Bitmap From MMapped #363

jacksonrnewhouse opened this issue Jun 24, 2022 · 2 comments

Comments

@jacksonrnewhouse
Copy link

We have been trying to use Frozen Bitmaps for our internal system and were met with unanticipated faults. After working with @a392n328 we were able to write up this minimal failure, which is in #362. The actual error is

=== RUN   TestFrozenCases
unexpected fault address 0x15fb008
fatal error: fault
[signal SIGBUS: bus error code=0x2 addr=0x15fb008 pc=0x11ed56a]

I can't figure out what exactly could be causing this.

@lemire
Copy link
Member

lemire commented Jun 25, 2022

Though it may well work, I should point out that we have no tests where we mutate the result of a FrozenView. My assumption has always been that the result of a FrozenView was to be considered immutable (frozen). You are treating frozen views as mutable... but we have no test that I can see that check that this is ok.

The frozen format was definitively created for immutable bitmaps. The idea was that you have something on disk that you just want to access (not modify). It may well be that our Go implementation supports mutations... but I'd like to see more tests.

@lemire
Copy link
Member

lemire commented Jun 25, 2022

A SIGBUS would suggest a buffer overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants