Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitSliceIndexing BSI sub-library correctly stores twos complement values but range comparisons fail for negative values. #315

Open
guymolinari opened this issue Jun 14, 2021 · 2 comments
Assignees

Comments

@guymolinari
Copy link
Contributor

Negative values are correctly stored and retrieved, however when performing any comparisons LT, GT, GE, LE, RANGE against negative values they fail horribly.

@lemire
Copy link
Member

lemire commented Jun 14, 2021

@guymolinari Couldn't we document that we are supporting only non-negative values? That was my expectation.

@guymolinari
Copy link
Contributor Author

guymolinari commented Jun 14, 2021 via email

@guymolinari guymolinari self-assigned this Jun 14, 2021
lemire added a commit that referenced this issue Jun 15, 2021
Fix issue #315, Negative BSI values fail range comparisons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants