Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow pentru pull requests #6

Open
ionelmc opened this issue May 9, 2015 · 3 comments
Open

Workflow pentru pull requests #6

ionelmc opened this issue May 9, 2015 · 3 comments

Comments

@ionelmc
Copy link
Member

ionelmc commented May 9, 2015

Am putea avea un workflow de genul:

  • Cineva face fork, adauga un eveniment/pagina si dupa aceea face un PR
  • TravisCI ruleaza Pelican si publica HTMLul undeva (pentru review)
  • Daca e ok si se face merge la PR, TravisCI ruleaza din nou buildul, dar de data asta (fiindca nu e PR) face si deploy

Vis-a-vis de deploy, in TravisCI se pot stoca "secrete": http://docs.travis-ci.com/user/environment-variables/#Secure-Variables

@ionelmc ionelmc changed the title Workflow PRs Workflow pull requests May 9, 2015
@ionelmc ionelmc changed the title Workflow pull requests Workflow pentru pull requests May 9, 2015
@rciorba
Copy link

rciorba commented May 10, 2015

Sună ok workflow-ul propus. Numai că apare întrebarea: cine poate să facă merge?

@PCManticore
Copy link
Member

Cine are drept de merge, ergo cineva din RoPython. Altfel nu văd de ce ar veni o terță persoană pentru a-și adăuga un eveniment ce ține de cu totul altceva.

@ionelmc
Copy link
Member Author

ionelmc commented May 10, 2015

Eu ma gandeam la PR ca si un workflow de drafting la anunt (cand sunt mai multi organizatori la un eveniment). E complet optional adica.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants