Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webusb transport for Ledger Nano #227

Merged
merged 10 commits into from Jun 13, 2019
Merged

Conversation

TobiaszCudnik
Copy link
Contributor

@TobiaszCudnik TobiaszCudnik commented Apr 25, 2019

This PR switches the Ledger support to webusb (fixes #224).

Included:

  • ledger signing supports every type of transaction
  • deep linking has UI element to activate webusb
  • last used device is remembered
  • user can unmount the device from the left menu

To test one has to have the newest (not yet released as of now) rise ledger-app.

Beta release:
https://github.com/RiseVision/rise-react-wallet/releases/tag/v1.2.0-beta2

Screenshots:
Screen Shot 2019-04-30 at 2 05 08 PM
Screen Shot 2019-04-30 at 2 05 53 PM

- fixed deep linking (button to activate webusb)
- remember last used ledger
- button to unmount ledger
@TobiaszCudnik TobiaszCudnik merged commit abf5602 into master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ledger U2F timeout issue
1 participant