Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks for setting a passphrase sometimes dont catch requests #194

Open
TobiaszCudnik opened this issue Jan 28, 2019 · 0 comments
Open

Mocks for setting a passphrase sometimes dont catch requests #194

TobiaszCudnik opened this issue Jan 28, 2019 · 0 comments
Labels
bug Something isn't working tests

Comments

@TobiaszCudnik
Copy link
Contributor

Mocks for setting the password sometimes dont catch requests, resulting in the second fixture account having a passphrase set. This break tests depending on non-set passphrase (eg testing of setting a passphrase).

Temporary fix:

  • create a new account
  • transfer funds
  • update the fixture file and yarn encrypt-fixtures

Proper fix is to implement #77.
@TobiaszCudnik TobiaszCudnik added bug Something isn't working tests labels Jan 28, 2019
@TobiaszCudnik TobiaszCudnik changed the title Mocks for setting the password sometimes dont catch requests Mocks for setting a passphrase sometimes dont catch requests Jan 28, 2019
TobiaszCudnik added a commit that referenced this issue Feb 21, 2019
@TobiaszCudnik
disable affected tests #194
e08deb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TobiaszCudnik