Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueBox without subtitle or footer #337

Open
muschellij2 opened this issue Mar 10, 2023 · 0 comments
Open

ValueBox without subtitle or footer #337

muschellij2 opened this issue Mar 10, 2023 · 0 comments

Comments

@muschellij2
Copy link

My use case was to have a ValueBox without a subtitle or footer.

The issue is that even when you specify subtitle = NULL, you still will get <p class="small-box-subtitle"></p> as shiny::tags$p(class = "small-box-subtitle", subtitle) will still result in a tag, which is executed at:
https://github.com/RinteRface/bs4Dash/blob/master/R/cards.R#L778

Also, with the default footer = NULL, there is space that is added to the valuebox that is not desirable:
https://github.com/RinteRface/bs4Dash/blob/master/R/cards.R#L805

I have added a PR at #289 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant