Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

✨ Implement individual Configurable HyperOptable Weighted Signals #237

Open
Rikj000 opened this issue Jan 17, 2022 · 4 comments
Open

✨ Implement individual Configurable HyperOptable Weighted Signals #237

Rikj000 opened this issue Jan 17, 2022 · 4 comments
Labels
Feature - Cleanup Remove unneeded files Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request In Progress This is being worked on
Milestone

Comments

@Rikj000
Copy link
Owner

Rikj000 commented Jan 17, 2022

In the current MoniGoMani implementation we are limited to only being able to adjust the search space for all weighted signals at once.

The idea here would be to make the search spaces for individual weighted signals easily configurable in MoniGoManiHyperStrategy.py.

🔲 Each weighted signal should have following settings:

  • min
  • max
  • threshold
  • type

So it will align with the new protection_spaces format.

🔲 Then we can just use following settings from mgm-config as default values, if no specific ones are added in MoniGoManiHyperStrategy.py:

  • min_weighted_signal_value
  • max_weighted_signal_value
  • search_threshold_weighted_signal_values

🔲 Finally we should re-work the documentation for this

@raftersvk is currently working on this on his separation-of-signals-into-triggers-and-guards branch,
and it was already showing promising results!

Early POC example:
early_example

@Rikj000 Rikj000 added Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request Feature - Cleanup Remove unneeded files In Progress This is being worked on labels Jan 17, 2022
@Rikj000 Rikj000 added this to Planned in MoniGoMani - Global Development Progress via automation Jan 17, 2022
@Rikj000
Copy link
Owner Author

Rikj000 commented Jan 17, 2022

Linking to issue: #236

@Rikj000 Rikj000 added this to the v1.0.0 milestone Jan 17, 2022
@Rikj000 Rikj000 moved this from Planned to In Progress in MoniGoMani - Global Development Progress Jan 17, 2022
@raftersvk
Copy link
Contributor

raftersvk commented Jan 19, 2022

Before continuing with my work, one question:
Do you really want to get rid of the following mgm-config values?

  • min_weighted_signal_value
  • max_weighted_signal_value
  • search_threshold_weighted_signal_values

So far I kept them as default values if None were given on the individual signal.
Both are valid concepts, just let me know what you prefer.

@Rikj000
Copy link
Owner Author

Rikj000 commented Jan 19, 2022

Do you really want to get rid of the following mgm-config values?

  • min_weighted_signal_value
  • max_weighted_signal_value
  • search_threshold_weighted_signal_values

So far I kept them as default values if None were given on the individual signal.

That's a good idea, to keep them as default values! 😄

@raftersvk
Copy link
Contributor

check this #247

@Rikj000 Rikj000 linked a pull request Jan 30, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature - Cleanup Remove unneeded files Feature - Enhancement Update or improvement to existing feature Feature - New New feature or pull request In Progress This is being worked on
Development

No branches or pull requests

2 participants