-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More grass layers do grass blades in same places. #3128
Comments
I found out where I fixed it in PagedGeom.
We have PagedGeom sources inside old SR, this is an older fork of it. Probably all those later are needed to fix this too: |
To be honest, I think the PaGeom grass is ugly and unoptimal either way. PaGeom itself is weird: Personally I'd rather dump Paged grass altogether and used the #3030 feats to generate more detailed grass in bigger batches, possibly using the shell texturing trick or combined |
Sure, I agree PagedGeom is the worst now. But this is a quick fix for current issue. |
The new system for grass will come as side effect of #3030 that I keep pointing you to :) I'm intensively focusing on that and it will be done at the end of February latest, though probably earlier. Though yes, a quick fix for the PagedGrass would be good. But we have paged sources outside of our tree: https://github.com/RigsOfRods/rigs-of-rods/blob/master/conanfile.py#L20 and IIRC the I'm sure the community would appreciate a roadmap but I was never able to follow one, I get incredibly frustrated fixing the minor glitches that bother players and I escape to more fundamental things that the community hardly cares about. But most importantly, I'm the only dev around who's able to look at the codebase hollisitically, others just do narrow (though major in gameplay/quality-of-life gain) features. |
Ah okay. Yeah there is so much stuff in #3030 that I didn't expect grass there too :) |
Well thats my wishful thinking anyway. I'll create a prototype grass generator soon, but I can't predict how the community will react, the paged grass isnt ugly 100% of the time. @AnotherFoxGuy how would you approach this? Create a patched Conan package or try to override GrassLoader in game source? |
@ohlidalp Why not submit the patch upstream? |
Ah good. Where is it? |
We use this repo: https://github.com/RigsOfRods/ogre-pagedgeometry |
Ok made a PR |
Merged in good faith - I didn't find time to build it. |
Okay. @AnotherFoxGuy this probably needs updating deps right, could you do it? |
I will update the package soon |
Having more grass layers in .tobj creates grass blades in same places.
Looks odd and due to grass sway they switch between each other.
Very long ago we were fixing such issues in PagedGeom, maybe something useful is in our PagedGeom code in old Stunt Rally. I don't remember where, but surely randomness (also grass placing) is bad in PagedGeom, and it needs to not reset seed for each grass layer. Or set seed to random from time.
The text was updated successfully, but these errors were encountered: