Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input sources for cruise control for the dashboard system #3113

Open
MarkROR opened this issue Jan 1, 2024 · 3 comments
Open

Add input sources for cruise control for the dashboard system #3113

MarkROR opened this issue Jan 1, 2024 · 3 comments

Comments

@MarkROR
Copy link
Contributor

MarkROR commented Jan 1, 2024

RoR has a cruise control feature - toggled on/off with the spacebar. However, there is no way of knowing if you have successfully activated it (some vehicles won't let you activate it, unless you've reached a certain speed) or if you've accidentally disabled it by e.g. braking slightly.

Having a visual indicator (a dashboard light) would be very helpful, I think.

We could provide an input source for making this possible in the future:
cruisecontrol or cruisecontrol_active true if cruise control is on

While we're here, we could also provide the value it has been set to:
cruisecontrol_kph cruise control set speed value, in kilometers per hour
cruisecontrol_mph cruise control set speed value, in miles per hour
These two would be useful, because they'd show you the set value instantly while you're adjusting the set speed with CTRL+R/CTRL+F

@ohlidalp
Copy link
Member

ohlidalp commented Jan 8, 2024

Hi, you're right, those are missing. I'll go for cruisecontrol_active and the rest.

Also it looks like the dash system still lives in the past regarding to lights. So I'll also add lowbeams, highbeams, foglights etc... Also userlights_N for 'u' type flares.

@MarkROR
Copy link
Contributor Author

MarkROR commented Jan 8, 2024

Awesome 👍

I believe the input sources/links you mentioned are already present, but named as sidelights, headlights, highbeams, foglights and custom_lightX where X is the number of the user-controlled flare New vehicle light types and controls

Unless I am misunderstanding something

@ohlidalp
Copy link
Member

ohlidalp commented Feb 9, 2024

Right, memory failed me again. Docs need to update.

Also consider difflock and xWD https://discord.com/channels/136544456244461568/189904947649708032/1205431235392970832

Also to be considered: glowplugs https://discord.com/channels/136544456244461568/189904947649708032/1205514849166172160

MarkROR added a commit to MarkROR/rigs-of-rods that referenced this issue Feb 10, 2024
New: `sidelights/headlights/highbeams/foglights` and `cruisecontrol_active`. These were introduced in RigsOfRods#2937, `cruisecontrol_active` will be introduced in the future RigsOfRods#3113 and when more (difflock, 4wd, etc) get added, we may have to think about a new dash/gui/hud or a dedicated panel for these lights

The reason the new lights are smaller than the old ones is so RoR doesn't have to resize them - they have been exported at the exact resolution they will be displayed on the screen, no resizing = best quality.
ohlidalp pushed a commit that referenced this issue Mar 25, 2024
New: `sidelights/headlights/highbeams/foglights` and `cruisecontrol_active`. These were introduced in #2937, `cruisecontrol_active` will be introduced in the future #3113 and when more (difflock, 4wd, etc) get added, we may have to think about a new dash/gui/hud or a dedicated panel for these lights

The reason the new lights are smaller than the old ones is so RoR doesn't have to resize them - they have been exported at the exact resolution they will be displayed on the screen, no resizing = best quality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants