Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce comprehensive test suite #218

Open
RichiH opened this issue Feb 26, 2017 · 3 comments · May be fixed by #220
Open

Introduce comprehensive test suite #218

RichiH opened this issue Feb 26, 2017 · 3 comments · May be fixed by #220

Comments

@RichiH
Copy link
Owner

RichiH commented Feb 26, 2017

As per #217, there seems to be a useful test suite growing. Thanks @djpohly :)

@djpohly
Copy link

djpohly commented Feb 26, 2017

Gotta pay for vcsh somehow. :)

I won't pretend the tests are full coverage - a few aspects like hooks/overlays, config variables, write-gitignore and list-untracked (which felt too complex) aren't tested at all yet. Plus a few tests are skipped due to current bugs in the code. But it's a starting point, it covers most of the core, and it made it feel a lot safer to make changes.

I had created some other "future" test files, but none of them contain anything useful yet. For the sake of giving other contributors ideas and/or not forgetting:

$ git status -u t/
t/configfiles.t
t/external-vars.t
t/hooks.t
t/list-untracked.t
t/overlays.t
t/write-gitignore.t

@RichiH
Copy link
Owner Author

RichiH commented Feb 26, 2017

https://travis-ci.org/RichiH/vcsh/builds/205618222 fails for me. Any idea what the cause might be? Might be able to poke it again tomorrow...

@djpohly
Copy link

djpohly commented Feb 26, 2017

Ah, djpohly/vcsh_testrepo.git has some additional branches and stuff. Ideally it wouldn't depend on an external repo (like the Git testsuite), but for now this works.

@RichiH, I made some important fixes to the tests this evening (there was a potential for false passes). They are now both pushed to bats and merged into refactor.

@alerque alerque linked a pull request Apr 2, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants