Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no ZWL currency #131

Open
dkasenka opened this issue Jun 6, 2023 · 2 comments
Open

There is no ZWL currency #131

dkasenka opened this issue Jun 6, 2023 · 2 comments

Comments

@dkasenka
Copy link
Contributor

dkasenka commented Jun 6, 2023 •
edited

Hi guys

I've found out that the library doesn't include ZWL.
https://github.com/Rhymond/go-money/blob/master/currency.go#L48

ZWL must replace ZWD according to ISO_4217: https://en.wikipedia.org/wiki/ISO_4217

Please fix it.
@Rhymond
Copy link
Owner

Rhymond commented Jun 7, 2023

Hi

Thanks, you can create PR and include missing currency. Please create a new record in the list to keep backwards compatibility, I think for now we should keep both currencies.

dkasenka added a commit to dkasenka/go-money that referenced this issue Jun 7, 2023
@dkasenka
Add ZWL currency Rhymond#131
090fe6d
@dkasenka dkasenka mentioned this issue Jun 7, 2023
Merged
Rhymond pushed a commit that referenced this issue Jun 7, 2023
@dkasenka
Add ZWL currency #131 (#132)
01f3174
@dkasenka dkasenka closed this as completed Jun 7, 2023
@dkasenka dkasenka mentioned this issue Jun 7, 2023
Merged
@dkasenka dkasenka reopened this Jun 7, 2023
@dkasenka
Copy link
Contributor Author

dkasenka commented Jun 7, 2023 •
edited

Also ZWD code must be 716 instead of 932
932 is for ZWL

justinbedia pushed a commit to justinbedia/money that referenced this issue Oct 1, 2023
Add ZWL currency Rhymond/go-money#131 (#132)
c4f72f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rhymond @dkasenka