Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic in binary.Unmarshal #603

Open
tie opened this issue Jul 27, 2021 · 0 comments · May be fixed by #615
Open

panic in binary.Unmarshal #603

tie opened this issue Jul 27, 2021 · 0 comments · May be fixed by #615

Comments

@tie
Copy link

tie commented Jul 27, 2021

What did you do?

Wrote a simple fuzz target using https://blog.golang.org/fuzz-beta. Immediately found first crasher.

binary.Unmarshal([]byte("\x00\xff\x80"))

https://play.golang.org/p/41B5GBalYFb

What did you expect to see?

An error.

What did you see instead?

panic: runtime error: slice bounds out of range [:-1]

Does this issue reproduce with the latest release?

Yes, I can reproduce the issue after upgrading to the latest commit.

go get github.com/Rhymen/go-whatsapp/binary@v0.1.2-0.20210714125832-447ed9cc6179
@dstdfx dstdfx linked a pull request Sep 7, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix panic in binary.Unmarshal dstdfx/go-whatsapp
1 participant
@tie