Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorCode description should be localized #3750

Open
ronyfadel opened this issue Mar 6, 2024 · 3 comments
Open

ErrorCode description should be localized #3750

ronyfadel opened this issue Mar 6, 2024 · 3 comments
Labels

Comments

@ronyfadel
Copy link

RevenueCat's RCPurchasesErrorCode is directly displayed to hundreds of thousands of users daily. It's a shame that the errors aren't localized.

Furthermore, some errors (e.g. storeProblemError) have underlying errors which would warrant a better localized description (such as 'no network connection' or any other storekit error)

@ronyfadel ronyfadel added the bug label Mar 6, 2024
@RCGitBot
Copy link
Contributor

RCGitBot commented Mar 6, 2024

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@aboedo
Copy link
Member

aboedo commented Mar 7, 2024

Hey @ronyfadel! Definitely valid feedback. Breaking it down into two components:

  • storeProblemError: yeah, this is fairly generic. Jacob told me about the issue you were having, I would have expected those to be translated into RC's paymentNotAllowedError, which would have been much more informative. Any chance you have logs and sysdiag for them? The expected behavior from StoreKit is that they'd send a paymentNotAllowed, but ASDErrorDomain errors are undocumented. We've captured a few manually and do some translation, but they can be hard to track down. If you send me logs, I'm happy to file a radar and get the codes mapped more nicely to paymentNotAllowed.

  • Errors that would warrant better localized description: absolutely agree. We've historically relied on returning error codes, and expecting developers to translate the messages into something user-friendly themselves, but, this feels like an outdated assumption at this point. A lot of devs just want an easy way to display an error to a user, and it's something we could do. We've had a tough time with proper localization for paywalls, but I'd like to find a way to do it nicely on behalf of all RevenueCat customers

@ronyfadel
Copy link
Author

@aboedo I'll email you, let's dig into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants