Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

√ Now it works on Redmine 4.0+ (Rails 5.2) #87

Open
windviki opened this issue Sep 11, 2019 · 8 comments
Open

√ Now it works on Redmine 4.0+ (Rails 5.2) #87

windviki opened this issue Sep 11, 2019 · 8 comments

Comments

@windviki
Copy link

There's no response in this repo.

So I made a fork and adapt it to Redmine 4.0+ (Rails 5.2).

https://github.com/windviki/redmine_tagging

@windviki windviki changed the title ✅ Make it work on Redmine 4.0+ (Rails 5.2) Make it work on Redmine 4.0+ (Rails 5.2) Sep 11, 2019
@windviki windviki changed the title Make it work on Redmine 4.0+ (Rails 5.2) Now it work on Redmine 4.0+ (Rails 5.2) Sep 11, 2019
@windviki windviki changed the title Now it work on Redmine 4.0+ (Rails 5.2) √ Now it works on Redmine 4.0+ (Rails 5.2) Sep 11, 2019
@mrPsycho
Copy link

mrPsycho commented Sep 26, 2019

@windviki

can you fix it:

Started PUT "/projects/android-dev/wiki/Android_Dynamic_Feature_Delivery" for 212.142.71.220 at 2019-09-26 22:42:01 +0300
Processing by WikiController#update as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"4NNCQpW/IRHdj24Pqn94En29aDINJ4zXaF465aMTxI6j7KV/Afj0QnGOAx7i3G4Dc+fMZUEtt7ZP9TdMPB2qsZg==", "content"=>{"version"=>"1", "text"=>"h1. Android Dynamic Feature Delivery\r\n\r\nhh", "comments"=>""}, "wiki_page"=>{"tags"=>"", "parent_id"=>"2089"}, "commit"=>"Save", "project_id"=>"android-dev", "id"=>"Android_Dynamic_Feature_Delivery"}
  Current user: y.n (id=13)
Completed 500 Internal Server Error in 18ms (ActiveRecord: 5.3ms)

NoMethodError (undefined method `tags_to_update=' for nil:NilClass):

plugins/redmine_tagging/lib/tagging_plugin/tagging_patches.rb:19:in `update'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

?

@windviki
Copy link
Author

windviki commented Sep 29, 2019

A quick guess is that you dont have any wiki pages.
Or you can add three lines before plugins/redmine_tagging/lib/tagging_plugin/tagging_patches.rb:19.

            if @page.nil?
              return
            end

If it works, please let me know. Thanks. I dont have the test environment now.

@mrPsycho
Copy link

hi,

i did it:

  module WikiControllerPatch
    module WithTags
      def update
        if params[:wiki_page]
          if tags = params[:wiki_page][:tags]
            tags = TagsHelper.from_string(tags)
            if @page.nil?
              return
            end
            @page.tags_to_update = tags
          end
        end
        super
      end
    end
  end
end

and now i cant press Save :)

@mrPsycho
Copy link

  module WikiControllerPatch
    module WithTags
      def update
        if params[:wiki_page]
          if tags = params[:wiki_page][:tags]
            if @page.nil?
              return
            end
            tags = TagsHelper.from_string(tags)
            @page.tags_to_update = tags
          end
        end
        super
      end
    end
  end
end

same

@AnestisK
Copy link

We have the same issue, And yes, there are wiki pages.
Is it possible to get an update to fix this?

@Diabsou
Copy link

Diabsou commented Nov 4, 2020

Hello,

Same here.
There are wiki page also.

The error message is :

No template found for WikiController#update, rendering head :no_content

When using the inline tag option this error does not appears.

@windviki
Copy link
Author

windviki commented Nov 4, 2020

Hello,

Same here.
There are wiki page also.

The error message is :

No template found for WikiController#update, rendering head :no_content

When using the inline tag option this error does not appears.

Hi, you can try my fork https://github.com/windviki/redmine_tagging

If the error still comes out, make an issue at my repo with detailed error message (full message with line numbers, etc.).

@ZephOne
Copy link

ZephOne commented Nov 22, 2021

Hi @windviki,
actually, it is not possible to make issue on your repo, it does not seem to be activated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants