Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move close button? #102

Open
svanlaere opened this issue Aug 25, 2017 · 7 comments
Open

Move close button? #102

svanlaere opened this issue Aug 25, 2017 · 7 comments

Comments

@svanlaere
Copy link

svanlaere commented Aug 25, 2017

Perhaps not a real issue, but consider the markup for displaying alerts:
http://responsivebp.com/css/alerts/

Assuming that screenreaders read the button first instead of the more important message:
Would it not make more sence to move the close button after the desired message?

@JimBobSquarePants
Copy link
Member

@svanlaere Interesting question; I think you might well be correct. I shall check and if this is the case will change the content order to match read order.

@svanlaere
Copy link
Author

How can I contact you by e-mail?

@JimBobSquarePants
Copy link
Member

@svanlaere I'd like to keep all conversations public if that's ok. More helpful for others.

@JimBobSquarePants
Copy link
Member

@svanlaere I've updated this in the v5-dev branch. The button can now be placed before and after.

@JimBobSquarePants JimBobSquarePants added this to the V5.0.0 milestone Oct 27, 2017
@adityaraute
Copy link

So can this issue be closed now?

@JimBobSquarePants
Copy link
Member

Not until I release the thing I'd say.

@adityaraute
Copy link

Been a long time :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants