Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move onboarding configuration to an onboarding manager #48

Closed
p2 opened this issue May 12, 2015 · 3 comments
Closed

Move onboarding configuration to an onboarding manager #48

p2 opened this issue May 12, 2015 · 3 comments

Comments

@p2
Copy link
Member

p2 commented May 12, 2015

Similar to #47, code used to setup and configure onboarding could be moved to a onboarding manager class. This would free up the app delegate and allow for easy customization by subclassing. For simple tie in to the app, AppCore may ask the app delegate, via protocol, for the onboarding manager.

I'm not sure if onboarding should be rolled into consenting or stay separate. It seems to me keeping them separate is desirable so as to not create a huge manager class with slightly different responsibilities.

Also cf. #41

p2 added a commit to chb/AppCore that referenced this issue May 12, 2015
@peculiar
Copy link
Member

My vote is to make onboarding a separate concept from consent; consent will vary wildly from study to study.

@p2
Copy link
Member Author

p2 commented May 14, 2015

BTW this is being worked on in PR #49

@p2
Copy link
Member Author

p2 commented Aug 14, 2015

This has been implemented with #49 .

@p2 p2 closed this as completed Aug 14, 2015
Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this issue Jan 21, 2016
BRIDGE-652 Default handling of unsupported app version in AppCore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants