Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBBProfileViewController comparison looks odd #37

Closed
jwe-apple opened this issue May 6, 2015 · 1 comment · Fixed by #64
Closed

SBBProfileViewController comparison looks odd #37

jwe-apple opened this issue May 6, 2015 · 1 comment · Fixed by #64

Comments

@jwe-apple
Copy link
Member

Code uses the following comparison:

self.user.sharedOptionSelection != [NSNumber numberWithInteger:SBBConsentShareScopeNone]

This looks unlikely to be what's intended.

@p2
Copy link
Member

p2 commented May 15, 2015

To be able to reuse APCSharingOptionsViewController I'd make a new APCUser property, which could be an enum that can be mapped to SBBConsentShareScopeXy. Should I do that on a separate branch or the one I'm working on for #43 , where I'm converting APCUser to a protocol?

Edit: meaning this would also resolve this issue.

Edit 2: Oh wait, just realized I'm not actually using APCSharingOptionsViewController but a good old ORKConsentSharingStep.

p2 added a commit to chb/AppCore that referenced this issue May 15, 2015
Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this issue Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants