Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding process is tightly tied to AppDelegate, Sage and CoreData #24

Open
p2 opened this issue Apr 30, 2015 · 4 comments
Open

Onboarding process is tightly tied to AppDelegate, Sage and CoreData #24

p2 opened this issue Apr 30, 2015 · 4 comments

Comments

@p2
Copy link
Member

p2 commented Apr 30, 2015

Similar to issue #16 , the onboarding process, especially APCOnboarding and APCOnboardingTask, import all the things plus APCAppDelegate.h.

To make it usable with only parts of the onboarding process the header imports need to be cleaned up and some dependencies removed.

@p2
Copy link
Member Author

p2 commented Apr 30, 2015

This can be remedied by removing APCOnboarding.prepareScenes and letting its delegate supply the scenes/tasks it should perform. I'm in the process of getting this done, might run into other issues.

@p2
Copy link
Member Author

p2 commented May 4, 2015

I am working on cleaning this up on https://github.com/chb/AppCore/tree/develop/modularize_onboarding but it needs thorough refactoring in many areas.

@jwe-apple
Copy link
Member

@peculiar Could you have a look and recommend next steps? Thanks!

@p2
Copy link
Member Author

p2 commented May 4, 2015

What I currently have is that APCOnboarding asks the app delegate for all the different predefined scenes. It then creates steps for all the scenes and can start the process with only the scenes I have implemented (still WiP).

There are still dependencies I don't like very much, some view controllers for example ask the app delegate for the current user when probably the user should be known to APCOnboarding. And some view controllers handle their own step logic, and other things like this.

My current idea is to encapsulate everything into APCOnboarding and then a new app can subclass it to make it work as desired. The app delegate will be asked to create an instance of the desired class, as is already the case. Then all onboarding view controllers get a handle to that instance and all logic decisions delegated to it instead of asking the app delegate all the time.

Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this issue Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants