Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userProfileElements property on APCPermissionsManager is not a permission type #118

Open
ghost opened this issue Jul 27, 2015 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 27, 2015

APCPermissionsManager is effectively a global variable holding a representation of the configuration of permissions, returning the state of permissions, and requesting those permissions when necessary. While userInfoItemTypes behave like permissions, they are not actually permissions.

APCPermissionsManager has the following property in the header file:

@property (copy, nonatomic) NSArray *userInfoItemTypes;

The userInfoItemTypes are used to configure view controller elements by prepareContent() methods in APCProfileViewController, APCSignUpMedicalInfoViewController, and APCSignUpGeneralInfoViewController.

A future review of this architecture might for example, add a userInfoConfiguration object to resolve this issue. Discussion in #117 recommended that neither APCPermissionsManager or APCOnboardingManager be the home for the array of userInfoItemTypes.

Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this issue Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants