Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine p2 update site process #189

Open
andylowry opened this issue Aug 21, 2018 · 0 comments
Open

Refine p2 update site process #189

andylowry opened this issue Aug 21, 2018 · 0 comments

Comments

@andylowry
Copy link
Contributor

Second pass at p2/pom.xml and the associated build script, including things like:

  • refining configured instructions to get to a working update stie
  • excluding artifacts known not to be needed (e.g. discovered transitive dependencies that we never use)
  • break the --repo build script arg into separate repos for KZOP and JOvl
andylowry added a commit that referenced this issue Aug 21, 2018
@andylowry
[#189] Changes to p2 site generation
0ecda8d 
* split -r option into separate options (-K and -J) for staging repos
  for KZOP and JOvl
* make direct imports non-optional
* add direct import for javax.mail.internet
* exclude JOvl from KZOP artifact (else we could ned up with two
  versions in the update site)
* don't export the .gen package from JOvl, and mark its import in KZOP
  optional (would be better to not import it, but not sure how to
  specify that)
* exclude artifacts only used by the JOvl gen package
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] New replacement for Messages class
5dc109b 
The old one is still there, where it's always been. The new
implementation is in the val.msg package.

The new implemnetation has these improvements:
* No longer includes inline messages, but messages are identified by
  enum values, and it's easy to navigate to the enum definition, where
  the default message appears.
* Properties files can be used to provide localized messages, either for
  a specific two-part language tag (e.g. "en-US") or by a language
  id ("en") as a fallback.
* Multiple enum classes can easily be defined for different sets of
  messages, and they can all be used as needed in the application

This makes it slightly more complicated to compose a new message, but
the resulting code is much more concise, and with an easy click-through
to the default message, this gets around the main issue I've had with
the eclipse org.eclipse.osgi.util.NLS class.
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] Exclude guava from the update site
e45927b
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] Upgraded existing validations to new msg scheme
4428b5c 
In the process, improved some message texts, and more importantly,
created place holders in the messasge texts for message parameters,
rather than just appending the paramters in a list after the message, as
had been done earlier. (It was never intended to stay that way!)
@andylowry andylowry mentioned this issue Aug 22, 2018
Closed
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
Revert "[#189] Upgraded existing validations to new msg scheme"
94f1690 
This reverts commit 4428b5c.

This change was intended for a separate branch
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
Revert "[#189] New replacement for Messages class"
3d8fda5 
This reverts commit 5dc109b.

This change was intended for a different branch
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] New replacement for Messages class
484ea98 
The old one is still there, where it's always been. The new
implementation is in the val.msg package.

The new implemnetation has these improvements:
* No longer includes inline messages, but messages are identified by
  enum values, and it's easy to navigate to the enum definition, where
  the default message appears.
* Properties files can be used to provide localized messages, either for
  a specific two-part language tag (e.g. "en-US") or by a language
  id ("en") as a fallback.
* Multiple enum classes can easily be defined for different sets of
  messages, and they can all be used as needed in the application

This makes it slightly more complicated to compose a new message, but
the resulting code is much more concise, and with an easy click-through
to the default message, this gets around the main issue I've had with
the eclipse org.eclipse.osgi.util.NLS class.
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] Upgraded existing validations to new msg scheme
401e321 
In the process, improved some message texts, and more importantly,
created place holders in the messasge texts for message parameters,
rather than just appending the paramters in a list after the message, as
had been done earlier. (It was never intended to stay that way!)
andylowry added a commit that referenced this issue Aug 22, 2018
@andylowry
[#189] add new package to exports for KZOP
6d22992
andylowry added a commit that referenced this issue Aug 26, 2018
@andylowry
[#189] Add option to publish to /latest site
494f2de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andylowry