Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image on CV #6

Open
zivlakmilos opened this issue Dec 26, 2023 · 2 comments
Open

Image on CV #6

zivlakmilos opened this issue Dec 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@zivlakmilos
Copy link

Hello,

It would be nice if users can upload optional image for CV. Maybe put it in top corner somewhere. I can help with development of this feature if you like idea.

@Renovamen
Copy link
Owner

Sorry for the late reply; I've been quite overwhelmed these past few months and overlooked some issues.

The idea of adding an image sounds great, and thanks to #7 — which I also missed — we have a potential way to insert images via an external URL. However, I think we need to think more about certain details before moving forward. For instance, we should adjust the resume header styles when adding an image, such as aligning it to the right or left. Additionally, it would be helpful if we could adjust the image's position (left/right), size, and corner roundness. I'm also considering saving images directly in the browser as base64 to enhance offline resume management. This would require some changes to the current storage setup, but that can be addressed later.

Do you have any thoughts on this? Thank you for your comments!

@Renovamen Renovamen added the enhancement New feature or request label May 3, 2024
@zivlakmilos
Copy link
Author

Hello,

No problem, I understand.
I think base64 would be preferred for privacy. Some people don't like having they images publicly available.
For me personally it's not big deal, but option to upload image and encode it in base64 would be better.

Also, it would be nice to choose image position (left/right) and corner roundness, but I don't think it's a big deal to start without that options, and add it latter it's complicate to implement it.

I you'd like assistance with implementation, feel free to let me know. I will be glad to help. I like project. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants