Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas and thank you! #1

Open
thecrazy opened this issue Jan 8, 2019 · 2 comments
Open

Some ideas and thank you! #1

thecrazy opened this issue Jan 8, 2019 · 2 comments

Comments

@thecrazy
Copy link

thecrazy commented Jan 8, 2019

I think im going to use the green vertex color channel to add another part to the tree. Some of our trees have lianas hanging that would look better if they behaved differently. Not sure if you take into account the intensity of the color value but if not, it would be a nice way of allowing extra control for all the parts of the tree ie.: having the branches and leaves move/wiggle more the further they are from the trunc. I guess a float value could also work (distance from trunc) but would be less flexible (altough im not sure if the flexibility would really be usefull). Gotta run some tests.

Edit: Just checked and it seems you allready take into account the "size" of a color value which is very nice!

Also, I was thinking that introducing stuttering settings for the leaves may look good. If the wind makes the tree stutter... the leaves should definitly stutter too. Could be additive to the trunc's stutter.

I'll post some code when I get around to it but it may take a while before I tackle it.

Thanks for making this shader, it works great!

Fred.

@RenanBomtempo
Copy link
Owner

Hey Fred,

First of all, thank you so much for using the shader and experimenting with it. I really appreciate the feedback and couldn't be happier seeing that people actually find it usefull.

I'll take note of the points you brought up. It's been a long time since I worked on this shader and I'm feeling really bad that I didn't keep up with the promise of updating it and investing time on it. I'll do my best to get it up to date and make sure that it becomes the best shader I can possibly create.

Renan.

@pourya0111
Copy link

Hello there
Wonderfull shader btw
But theres an question
We are working on a mobile project and the performance is on top of every considirations
So i want to know is this shader mobile friendly?
And if theres something to have it more performant,Can you just please mention them here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants