Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port handling in options.js and storage.js does not allow subdirectory reverse proxy configurations for Pyload #16

Open
slashmach1 opened this issue Jul 4, 2022 · 8 comments

Comments

@slashmach1
Copy link

because serverIP and port variables are always concated in a set fashion the url handling does not allow for subdirectory configurations for those utilizing a reverse proxy for pyload. By simply omitting port from storage.js and options.js. i was able to make it work since its always https 443. Other than that it works great!

@slashmach1
Copy link
Author

just to note; had to retool the server validation line likeso
const isValidName = /^(?!://)([a-zA-Z0-9]+.)?[a-zA-Z0-9][a-zA-Z0-9-]+.[a-zA-Z]+/[a-zA-Z0-9]{2,6}?$/i.test(value);

@lgrenier
Copy link

Same problem,
my pyload is behind a proxy and has the "Path Prefix" set.
So I can't use the parameter fields with my configuration.
I tried to modify the extension files as slashmach1 did, but my firefox does not want to install unsigned extensions...

@slashmach1
Copy link
Author

i should mention my work and testing were on the Chrome version of the extension. additional steps may be needed for firefox

@lnhrdt
Copy link

lnhrdt commented Aug 25, 2022

Same here, the plugin configuration tries to login at an invalid URL e.g. https://mydomain.com/pyload:443/api/login.

@RemiRigal
Copy link
Owner

The new version of Yape now supports subdiretory/path on top of the base URL, there is a new input field in the options page as well as an explicit view of the current URL for convenience and clarity.

Preview:
image

Feedbacks are welcome !

@lgrenier
Copy link

Thanks for the new option, but it does not seem to save the field "PyLoad server's path"
when I put it and save, the plugin says "You are logged in "
and when I reload the plugin options, the field shows only /
and it does not work...

@RemiRigal
Copy link
Owner

Thank you for the feedback @lgrenier, the issue has been fixed in version v1.1.2.

@lgrenier
Copy link

It works !
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants