Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the warning/error message, expected identifier to correctly identify the issue #469

Open
adhadse opened this issue Jun 11, 2023 · 3 comments

Comments

@adhadse
Copy link

adhadse commented Jun 11, 2023

Adding extra , at the end of a widget written inside a view macro generates this vague warning and error:
image
Removing the extra comma make it go away:
image

Other times, I came across this when trying to add a named child to GtkStack:
image
Which should be resolved using a ::

image

What can be done to improve the user to understand the underlying problem neatly?

@AaronErhardt
Copy link
Member

Thanks for your report! Does this issue still appear in 0.6?

Also, the last error is valid though, no?

@adhadse
Copy link
Author

adhadse commented Jun 12, 2023

Yes, I'm on 0.6.

The last error does confuse me, probably it could be just Did you confuse with =/: ... warning would have made sense 🤔

@AaronErhardt
Copy link
Member

I've just merged #470 which fixes the first issue. The second issue needs a little bit more work, but it is not too bad IMO because it makes sense that the macro expects an identifier after a =.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants