Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add J And L Hotkeys Please #541

Closed
HARANARATE opened this issue Feb 25, 2024 · 4 comments
Closed

Add J And L Hotkeys Please #541

HARANARATE opened this issue Feb 25, 2024 · 4 comments
Labels
bug Something isn't working classic player This issue affects one or more classic player options. It does not affect the latest player. experimental feature

Comments

@HARANARATE
Copy link

HARANARATE commented Feb 25, 2024

Describe the feature

The Video Player 2014 Lacks Three Hotkeys.
First Is J That Makes Video The Rewind By 10 Seconds.
Second Is K That Makes The Video Pause.
Third Is L That Makes The Video Fast Forward By 10 Seconds.
The Hotkeys J And L Were Made Back In 2013 And Here Is The Proof:
https://www.reddit.com/r/LifeProTips/comments/1h69bn/lpt_press_k_to_pause_your_youtube_video_instead/?sort=old
fd
The Hotkey K Was Made Back In 2012 And Here Is The Proof:
https://www.reddit.com/r/LifeProTips/comments/ruh5k/lpt_while_on_a_youtube_video_hit_k_to_playpause/

@HARANARATE HARANARATE added the enhancement New feature or request label Feb 25, 2024
@YukisCoffee
Copy link
Member

This feature was not supported by old HTML5 players (before 2015), but we added an event listener to reimplement it for the 2014 player anyways. But the implementation is a little buggy at the moment, and it only applies if you hard refresh on the watch page.

@HARANARATE
Copy link
Author

So You Will Have To Code It As A HTML5 Player For It To Work

@YukisCoffee
Copy link
Member

The player is already HTML5, and the code to add this extra feature already exists; it just doesn't get executed unless you hard refresh a page because of a Rehike bug.

@YukisCoffee YukisCoffee added bug Something isn't working and removed enhancement New feature or request labels Feb 26, 2024
@kawapure kawapure added the classic player This issue affects one or more classic player options. It does not affect the latest player. label Jun 8, 2024
@kawapure
Copy link
Member

kawapure commented Jun 8, 2024

The aforementioned bug ("it just doesn't get executed unless you hard refresh a page because of a Rehike bug") has since been fixed. Closing...

@kawapure kawapure closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classic player This issue affects one or more classic player options. It does not affect the latest player. experimental feature
Projects
None yet
Development

No branches or pull requests

3 participants