Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015 modern player quality settings have incorrect scaling/spacing #527

Open
SpinThwomp opened this issue Feb 10, 2024 · 3 comments
Open
Labels
bug Something isn't working classic player This issue affects one or more classic player options. It does not affect the latest player. experimental feature

Comments

@SpinThwomp
Copy link

SpinThwomp commented Feb 10, 2024

Rehike version

0.8.0

Operating system

MacOs 14.3

PHP version

8.2.4

What's going on?

when the options menu for video quality has every option up to 1080, it seems that the space between each quality setting is too large, leading to a large, ugly scrollbar at the side of the menu. Ironically, the window is the correct size, it is just the size of the options that bring about this behavior. see below:

Rehike:
Screenshot 2024-02-10 at 1 31 18 PM

Non-Rehike example:
Screenshot 2024-02-10 at 1 34 59 PM

The two overlayed atop each other:
Screenshot 2024-02-10 at 1 37 01 PM

(also the mini player option shows up for me in full screen and it doesnt for any footage of the 2015 player ive seen to date, is this a browser dependent thing?)

@SpinThwomp SpinThwomp added the bug Something isn't working label Feb 10, 2024
@TorutheRedFox
Copy link
Contributor

likely a different revision of the player, this is the earliest one after its rollout (from August 28th 2015 iirc)

@SpinThwomp
Copy link
Author

could similar spacing be implemented as a player config option? its really not the biggest deal but it is an annoying inconsistency.

@TorutheRedFox
Copy link
Contributor

tbh you can do this using css

@kawapure kawapure added the classic player This issue affects one or more classic player options. It does not affect the latest player. label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working classic player This issue affects one or more classic player options. It does not affect the latest player. experimental feature
Projects
None yet
Development

No branches or pull requests

4 participants