Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New comment model completely destroys comments. #505

Closed
aubymori opened this issue Jan 31, 2024 · 9 comments
Closed

New comment model completely destroys comments. #505

aubymori opened this issue Jan 31, 2024 · 9 comments
Labels
bug Something isn't working InnerTube parsing This issue has to do with the parsing of InnerTube responses.

Comments

@aubymori
Copy link
Member

Jesus Christ. The monkeys have fucking done it again. They completely fucked comments. Now, instead of the commentThreadRenderer containing the comment data, like a SANE FUCKING API, they decided it would be a great idea to instead give it a key (commentKey) that refers to an object in a completely separate array (frameworkUpdates.entityBatchUpdate.mutations) which also have this key (entityKey) and have the actual comment content. I seriously did not think they could get any more retarded, but they've done it.

Anyways, here's a full next continuation response containing this FUCKTARDED change:

garbage.json

@aubymori aubymori added the bug Something isn't working label Jan 31, 2024
@aubymori
Copy link
Member Author

FYI, this has already completely fucked V3.

image

@ephemeralViolette
Copy link
Contributor

de6ac9d

I wrote a few classes to make parsing these pieces of shit easier, but it's still tedious and I don't want to work on it.

@YukisCoffee
Copy link
Member

I think this is mostly fixed now, but I'll keep the issue open in case there's anything else that's important.

@bluedragon-cairo
Copy link
Contributor

Now the like/dislike button on comments doesn't work, heart button is broken(all comments in my channel has hearts and my comment on other channel has a heart button), replying throws visual errors(though reloading shows my new reply) since about two weeks ago

@Xammand
Copy link

Xammand commented Apr 13, 2024

I can't add a comment or add a reply on any video, I also have the same issues as bluedragon.

@bluedragon-cairo
Copy link
Contributor

bluedragon-cairo commented Apr 15, 2024

Posting the comment shows infinite loading but reloading page shows your new comment as far as I know... I temporarily switched to Vorapis V3 until Rehike fixes comments again so not sure about now though

@syndiate
Copy link
Contributor

@bluedragon-cairo @Xammand Posting comments and liking/disliking comments work now, but posting replies still don't

@Xammand
Copy link

Xammand commented Apr 26, 2024

@syndiate Yup that stuff works and replies don't for me. I'm also still having issues where every comment on a video I post have the heart on them even though I never favorited them. Clicking on it doesn't do anything.

@kawapure kawapure added the InnerTube parsing This issue has to do with the parsing of InnerTube responses. label Jun 8, 2024
@kawapure
Copy link
Member

kawapure commented Jun 8, 2024

Comments have been back to regular functionality for a while now. This issue will be closed. Any new issues pertaining to comment viewmodel parsing should be opened separately.

@kawapure kawapure closed this as completed Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working InnerTube parsing This issue has to do with the parsing of InnerTube responses.
Projects
None yet
Development

No branches or pull requests

7 participants