Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply button sometimes just doesn't work #462

Closed
TorutheRedFox opened this issue Jan 8, 2024 · 4 comments
Closed

Reply button sometimes just doesn't work #462

TorutheRedFox opened this issue Jan 8, 2024 · 4 comments
Labels
bug Something isn't working InnerTube parsing This issue has to do with the parsing of InnerTube responses.

Comments

@TorutheRedFox
Copy link
Contributor

Rehike version

0.8.0

Operating system

Windows NT 10.0 22H2 19045.3086 (Windows 10 22H2)

PHP version

8.2.11

What's going on?

Sometimes the reply button doesn't work at all when you click it. This especially happens when trying to reply to a reply.

@TorutheRedFox TorutheRedFox added the bug Something isn't working label Jan 8, 2024
@ephemeralViolette
Copy link
Contributor

It occurs specifically when you try to reply to a linked comment.

@aubymori
Copy link
Member

aubymori commented Jan 8, 2024

simplebox in general is a broken piece of shit

@kawapure kawapure added the InnerTube parsing This issue has to do with the parsing of InnerTube responses. label Jun 8, 2024
@kawapure
Copy link
Member

This seems to be fixed since the view model transition. I guess whatever oversight it was was was exacerbated, because now linked replies just bake null comment renderers for the teaser renderer, which is a much more clear issue.

Since InnerTube doesn't seem to serve legacy comments anymore, I will close this issue.

@kawapure
Copy link
Member

Aforementioned problem fixed in 6234cce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working InnerTube parsing This issue has to do with the parsing of InnerTube responses.
Projects
None yet
Development

No branches or pull requests

4 participants