Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay settings do not persist #448

Closed
dollhaus opened this issue Dec 7, 2023 · 9 comments
Closed

Autoplay settings do not persist #448

dollhaus opened this issue Dec 7, 2023 · 9 comments
Labels
bug Something isn't working inactive This issue is inactive, and will be considered for closure if not followed up upon soon.

Comments

@dollhaus
Copy link

dollhaus commented Dec 7, 2023

Rehike version

0.8.0

Operating system

Windows NT 10.0 build 17763 (Windows Server 2019)

PHP version

8.2.4

What's going on?

  • build 1238, 2023-12-02

On pulling the current nightly available as of today, autoplay persists in it's enabled state, despite being toggled off.

This behaviour occurs when opening a new tab, but not when navigating to a video in the same tab. I have attached a demonstration below:
Sequence #1(1)-1.webm

@dollhaus dollhaus added the bug Something isn't working label Dec 7, 2023
@YukisCoffee
Copy link
Member

Does clearing cookies correct it? Depending how old the version you had before pulling, it may actually predate the bug in question.

If it was reintroduced, I will kill Aubrey.

@YukisCoffee
Copy link
Member

image

I am technically a few versions behind because I have some uncommitted changes, but it seems to be working alright for me.

@aubymori
Copy link
Member

aubymori commented Dec 7, 2023

Does clearing cookies correct it? Depending how old the version you had before pulling, it may actually predate the bug in question.

If it was reintroduced, I will kill Aubrey.

dawg it's not my fuckin fault literally the last change i made in like weeks is the comment mentions commit i did

@YukisCoffee
Copy link
Member

Does clearing cookies correct it? Depending how old the version you had before pulling, it may actually predate the bug in question.
If it was reintroduced, I will kill Aubrey.

dawg it's not my fuckin fault literally the last change i made in like weeks is the comment mentions commit i did

Daylin then.

@dollhaus
Copy link
Author

dollhaus commented Dec 7, 2023

Does clearing cookies correct it? Depending how old the version you had before pulling, it may actually predate the bug in question.

If it was reintroduced, I will kill Aubrey.

I didn't specifically test for this, but I did try it in another browser and in private browsing, neither of which changed this behaviour - human sacrifice notwithstanding.

The build I ran prior, and the one to which I reverted, is 2023-10-26.

@YukisCoffee
Copy link
Member

The issue is probably that you have multiple instances of the PREF cookie, one which is read by the server and one which is written to by the browser. There should only be one.

A Rehike bug was causing malformed duplicate PREF cookies to be formed, which causes the desynchronization. Indeed, the code responsible to generate this is gone, from what I can tell, but there are persistent side effects in reading it.

@dollhaus
Copy link
Author

dollhaus commented Dec 12, 2023

ya I had a fair few, perhaps fifty or so in all. Unfortunately, getting rid just results in a handful returning:

Capture

The majority of the previous entries were something to do with j(something)_kevlar_offset, with the path /s/desktop/<numerical id>/. That id was different for each entry.

Autoplay preference still doesn't appear to save, meantime I wrote a script to manage it.

@YukisCoffee
Copy link
Member

I wonder why the changes in 809e021 aren't affecting your use. Does this bug also affect private tabs? Indeed, you seem to have the same bug as before this change...

@kawapure kawapure added the inactive This issue is inactive, and will be considered for closure if not followed up upon soon. label Jun 8, 2024
@kawapure
Copy link
Member

kawapure commented Jun 8, 2024

I believe this issue has been patched. I'll close this unless more information is provided.

@kawapure kawapure closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working inactive This issue is inactive, and will be considered for closure if not followed up upon soon.
Projects
None yet
Development

No branches or pull requests

4 participants