Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for Schema.org Version #165

Open
Turnerj opened this issue May 3, 2020 · 2 comments
Open

Add metadata for Schema.org Version #165

Turnerj opened this issue May 3, 2020 · 2 comments
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. good first issue A good first issue for a new community member to take on. help wanted Help wanted from the community.

Comments

@Turnerj
Copy link
Collaborator

Turnerj commented May 3, 2020

Describe the feature

I'm not 100% sure we actually get this from our data source but it would be nice having a program-accessible constant that refers to the Schema.org version that the code is currently using.

@Turnerj Turnerj added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label May 3, 2020
@RehanSaeed
Copy link
Owner

Decent idea. It might be in one of the two JSON files we request.

@Turnerj
Copy link
Collaborator Author

Turnerj commented May 4, 2020

With our request to https://schema.org/version/latest/all-layers.jsonld, the @id property (currently) contains "https://schema.org/#8.0" so getting the version isn't too hard.

To get the version without a second HTTP request might be harder due to how the code in the tool handles the result - its designed to pass back only the schema classes.

Might need to think a little more about how I want to approach it. I know I've wanted to restructure the tool a bit to make working on it a little easier but I didn't want to overlap with potentially changing how the tool generates the classes (as like we've discussed before, source generators in .NET 5 might be the path forward).

@RehanSaeed RehanSaeed added help wanted Help wanted from the community. good first issue A good first issue for a new community member to take on. labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. good first issue A good first issue for a new community member to take on. help wanted Help wanted from the community.
Projects
None yet
Development

No branches or pull requests

2 participants