Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph support enhancement #132

Open
jtkent opened this issue Feb 4, 2020 · 6 comments · May be fixed by #182
Open

graph support enhancement #132

jtkent opened this issue Feb 4, 2020 · 6 comments · May be fixed by #182
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.

Comments

@jtkent
Copy link

jtkent commented Feb 4, 2020

Do you have any plans to implement the @graph syntax to allow for mulitple JSON-types to be written at once.

Example:
https://stackoverflow.com/questions/30505796/json-ld-schema-org-multiple-video-image-page/

This would allow for writing of only one script element rather than mulitple.

@jtkent jtkent added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Feb 4, 2020
@RehanSaeed RehanSaeed added the help wanted Help wanted from the community. label Feb 4, 2020
@RehanSaeed
Copy link
Owner

Interesting. I was not aware of the @graph property. I think it would be fairly straightforward to add a new property to the base JsonLdObject class:

[DataMember(Name = "@type", Order = 1)]
public virtual string Type { get; }

[DataMember(Name = "@graph", Order = 2)]
public virtual Thing Graph { get; }

The only reall work will be to add some smarts to the JSON serializer to switch between using the type property or the graph property.

@vmateianu
Copy link

This library is awesome, however missing support for entity graphs is a huge drawback.

https://yoast.com/regarding-googles-related-entities-patent/

@RehanSaeed
Copy link
Owner

Would be willing to take a PR if you're really interested.

@Turnerj Turnerj linked a pull request Jul 4, 2020 that will close this issue
@maraerben
Copy link

Any news here? Is it possible to merge enclosed MR #182 ? It would be very useful for us.

@Turnerj
Copy link
Collaborator

Turnerj commented Mar 29, 2023

Hey @maraerben - Currently #182 is only the most surface level changes needed, I haven't yet got around to any further development for it. My last comment on the PR covers generally what I think we'd need to do for graph support but it has been a while since I've taken a deep dive at it.

I don't know when I'd be getting back to it myself so I'd definitely welcome any PRs to add graph support in the mean time.

@wstaelens
Copy link

what is the status of @graph ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. help wanted Help wanted from the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants