Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join does not add component prefix to discriminator mapping if the name of the schema coincidentally contains the prefix. #1451

Open
simon-spinner opened this issue Feb 27, 2024 · 2 comments
Labels
good first issue Good for newcomers p3 Type: Bug Something isn't working

Comments

@simon-spinner
Copy link

Describe the bug

Assume a schema with name CreateSomethingRequest and join is called with --prefix-components-with-info-prop where the info property contains Something. Then the schema definition itself is prefixed, but references to that schema inside a discriminator mapping are not prefixed. This results in an invalid openapi.

OpenAPI description
3.0.4

Redocly Version(s)

1.9.1

Node.js Version(s)

Additional context

See comment https://github.com/Redocly/redocly-cli/pull/1444/files#r1504217718

@tatomyr
Copy link
Contributor

tatomyr commented Feb 27, 2024

Hi @simon-spinner! It looks like you know how to fix that. Just in case, we accept pull requests here 😉

@tatomyr tatomyr added p3 good first issue Good for newcomers labels Feb 27, 2024
@Ayush9026
Copy link

/assign @Ayush9026 i will solve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers p3 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants