Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bonfire should know it shouldn't keep trying it if can't pull image for iqe-cji pod #190

Open
Victoremepunto opened this issue Mar 2, 2022 · 2 comments

Comments

@Victoremepunto
Copy link
Collaborator

bonfire deployment timeout for me, I used the wrong Image tag but that wasn't handled properly by bonfire - I checked and I saw the image pull back off message on openshift - bonfire should be able to handle this and fail the deployment.

@bsquizz
Copy link
Collaborator

bsquizz commented Mar 2, 2022

Let's see if the ImagePullBackoff error appears anywhere in a pod's status conditions (I think it might but need to confirm)

At the moment we check the status conditions for a resource after it times out at this point: https://github.com/RedHatInsights/bonfire/blob/master/bonfire/openshift.py#L687

We could start checking these conditions during the observe call, somewhere in here: https://github.com/RedHatInsights/bonfire/blob/master/bonfire/openshift.py#L610-L619 and fail fast if we see image pull backoff errors on pods.

@bsquizz
Copy link
Collaborator

bsquizz commented Oct 25, 2023

RedHatInsights/ocviapy#9 will help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants