-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Selenium tests to continuous integration #89
Comments
After thinking about this for a day, am leaning towards...
|
This seems like a solid plan. My server is currently running PHP 8.1, specifically version 8.1.20. We could consider upgrading to PHP 8.2 to extend the support for PHP updates. It's worth noting that security updates for PHP 8.1 are scheduled to end in November, although this may vary depending on the distribution's support. |
|
Guessing an issue with your WebDriverIO is that your wdio-github.conf.js is using CommonJS syntax. while your package.json suggests your setup to use ES Modules. |
There is a ton of technical debt in this legacy code. Enough to keep a full time dev busy for a year upgrading everything.
I pretty much have no time to dedicate to this, which is why the repo has been inactive. There is very little public interest in this repo either, with only 9 stars and like 1 ticket/PR a year.
I think the place to start is to set up some automated tests that test against each PHP version. Then work from the bottom up fixing things broken in each version. So first PHP 7.0, then PHP 7.1, etc. Until the scripts run with no feature breakage and no fatal errors on the current PHP version, PHP 8.3.
Each PHP version should be paired with a version of MySQL that was typical for usage with that PHP version. Since MySQL versions can also cause breaking changes.
Now, what kind of tests? I'm not going to write proper unit and integration tests for this repo. That'd be too much work. We need something that can be set up quickly and detect broad changes. In my opinion, the options are...
I think trying to fix every deprecation, notice, and warning would be too much work as well. So we should set the test's error reporting to only report errors. We can put off fixing deprecations until the syntax is actually deprecated and causes a breakage.
The text was updated successfully, but these errors were encountered: