Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Switch from requests to aiohttp #81

Open
llamaair opened this issue Jun 25, 2023 · 1 comment
Open

[ENHANCEMENT] Switch from requests to aiohttp #81

llamaair opened this issue Jun 25, 2023 · 1 comment

Comments

@llamaair
Copy link

The requests library is not async and therefore blocking. This means that if 2 users run a command that uses requests, at the same time, it will take longer for the bot to respond to the second user than the first.

However, aiohttp is not blocking, which means that if 2 users execute the same command using the aiohttp library instead of requests, the bot will respond to both users at approximately the same time.

Therefore, I highly recommend switching from the requests library to aiohttp, or any other async library.

@RedTeaDev
Copy link
Member

See #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants