New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart titles are missing in demographic breakdown viz #571
Comments
@terryttsai can you look into this when you have a chance, or maybe just assign to Ilya since according to the "Additional Context" it seems like it might be the result of one of his changes! |
@terryttsai I know solution for this problem, so if you haven't done it by now, I could handle it. |
Thank you @nasaownsky !! |
Huh I thought I replied to this via email but I don't see my comment. I have a fix for this too: #573 Though poking around in the app, I see areas where we provide a legend on every bar rather than on the last bar, do we want to remove the legend in those places too? |
yes I agree the desired behavior in these scenarios would be to only show the legend once, since it's the same for both charts in the section |
@terryttsai what's the status on this? |
PR #573 is up for fixing the issue however we should create a new issue for removing the legends in areas where they're showing up more than once. |
I'll create the follow-up issue and merge #573 |
Thanks!! |
Follow-up issue: #575 |
Describe the bug
When viewing a demographic breakdown section (e.g., https://spotlight-staging.recidiviz.org/us-nd/narratives/probation/5), labels are missing on all but the last chart when you select a breakdown type.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Only the last chart should have a legend but all of the charts should have a title
Screenshots
Screenshots revealing sensitive information must not be shared. If a screenshot is helpful in diagnosing and resolving the bug, please send this directly to a contact on the Recidiviz team.
(this is not sensitive data)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Not evident in prod yet so it must be the result of an unreleased change (I believe 6dc8552) ... it appears that the prop that hides the legend is also inadvertently hiding the title in this situation)
The text was updated successfully, but these errors were encountered: